Repair WebAssembly CI by build script and IRGen test fix #76480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static SDK overlay has been built implicitly for a long time, but this is not the case anymore after 5bf2c93. We need to build it explicitly now.
The test was failing on 32-bit platforms because the offset of the layout of struct metadata depends on the pointer size. | Field | Type | Offset (32-bit) | Offset (64-bit) | |-------------------------|------|-----------------|-----------------| | Layout String Pointer | ptr | 4 * (-2) | 4 * (-4) | | VWT | ptr | 4 * (-1) | 4 * (-2) | | Metadata Flags | ptr | 4 * 0 | 4 * 0 | | Nominal Type Descriptor | ptr | 4 * 1 | 4 * 2 | | Generic Requirement | ptr | 4 * 2 | 4 * 4 | | Field Offset for handle | i32 | 4 * 3 | 4 * 6 | | Field Offset for value | i32 | 4 * 4 | 4 * 7 |
|
@swift-ci smoke test |
|
@swift-ci test WebAssembly |
MaxDesiatov
approved these changes
Sep 16, 2024
|
@swift-ci build toolchain |
Azoy
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static SDK overlay has been built implicitly for a long time, but this is not the case anymore after 5bf2c93. We need to build it explicitly now. Otherwise we get the following error:
The test was failing on 32-bit platforms because the offset of the layout of struct metadata depends on the pointer size.
handlevalue