[build] Disable checked iterators on Windows #76550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
compnerd,
etcwilde,
hyp,
al45tair and
hjyamauchi
|
@swift-ci please smoke test |
compnerd
reviewed
Sep 18, 2024
CMakeLists.txt
Outdated
| @@ -419,6 +419,16 @@ set(SWIFT_STDLIB_MSVC_RUNTIME_LIBRARY | |||
| ${SWIFT_STDLIB_MSVC_RUNTIME_LIBRARY_default} | |||
| CACHE STRING "MSVC Runtime Library for the standard library") | |||
|
|
|||
| if("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows" AND BOOTSTRAPPING_MODE STREQUAL "HOSTTOOLS") | |||
There was a problem hiding this comment.
This can only halogen in an unsupported build, as debug builds are known to be problematic in general. Can you please also add an explicit build configuration check here?
There was a problem hiding this comment.
Sure, added a check for a debug build.
Trying to run a debug build of the Swift compiler with a host Swift toolchain on Windows was failing with a linker error due to a mismatched `_ITERATOR_DEBUG_LEVEL` macro. This avoids the linker error by disabling bounds-checked iterators on Windows. See the inline comment for details.
egorzhdan
force-pushed
the
egorzhdan/msvc-checked-iterators
branch
from
0fe5b10 to
7fad3e7
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Sep 19, 2024
|
Yeah, I think being able to run a debug build is quite helpful, at least I tend to do that when investigating PR test failures on Windows. Looking forward to Windows debug builds being officially supported in the future 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run a debug build of the Swift compiler with a host Swift toolchain on Windows was failing with a linker error due to a mismatched
_ITERATOR_DEBUG_LEVELmacro.This avoids the linker error by disabling bounds-checked iterators on Windows. See the inline comment for details.