Remove feature guard on lifetime dependence inference #76588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test macOS platform |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
8c24e34 to
18c5322
Compare
|
@swift-ci smoke test macOS platform |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
18c5322 to
f02448b
Compare
|
@swift-ci smoke test macOS platform |
|
@swift-ci test |
meg-gupta
requested review from
hborla,
slavapestov,
xedin,
eeckstein,
jckarter,
zoecarver,
hyp,
egorzhdan,
rjmccall,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
beccadax and
ian-twilightcoder
as code owners
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
55ba1bd to
077ec17
Compare
|
@swift-ci test |
egorzhdan
requested changes
Sep 26, 2024
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
077ec17 to
32ca01d
Compare
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
2 times, most recently
from
cb0de0f to
f07ab0b
Compare
egorzhdan
approved these changes
Sep 27, 2024
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
f07ab0b to
47b7d6e
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
2 times, most recently
from
3555333 to
f25e383
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
f25e383 to
a9d317e
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
a9d317e to
b28d8c9
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
b28d8c9 to
055b153
Compare
|
@swift-ci test |
SwiftDeclSynthesizer::makeDefaultArgument does not create substituion map while creating the implicit FuncDecl which leads to TypeChecker complaining about the absence when there are type parameters. Avoid importing such C++ functions for now.
This PR introduces a `mapTypeIntoContext` in `InterfaceTypeRequest::evaluate` which introduces a cycle in this test.
We currently load it for prespecialization when it wasn't loaded initially. This causes an inadvertant issue for invertible protocols. When we don’t have the stdlib loaded initially, we “synthesize” the invertible protocol from the Builtin module by creating a new `ProtocolDecl*` and stashing it on the `ASTContext`. If the stdlib gets loaded later, deserialized stdlib types conform to the deserialized `Escapable` protocol which has a different `ProtocolDecl *` pointer for `Escapable`. So queries like `conformsToInvertible` fail because they are using the wrong `ProtocolDecl*` for `Copyable`/`Escapable` while looking up the ConformanceTable.
meg-gupta
force-pushed
the
lifetimeremovefeatureguardincompiler
branch
from
055b153 to
cf4832e
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifetime dependence inference runs on all function results that are ~Escapable. It was guarded by the NonEscapable feature flag. This PR removes the feature guard. This should theoretically be an NFC because ~Escapable types are flagged by Sema without the feature flag.