Ensure that bridged types are indirectly returned on Windows ARM64 #76589
Conversation
On Windows ARM64, how a struct value type is returned is sensitive to conditions including whether a user-defined constructor exists, etc. See https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#return-values That caused a calling convention mismatch between the non-USED_IN_CPP_SOURCE (Swift) side and the USE_IN_CPP_SOURCE (C++) side and a crash. Following swiftlang#76433 add constructors to several bridged C++ struct/class types so that the calling convention matches. This is a partial fix for swiftlang#74866
|
@swift-ci please test |
|
@swift-ci please test linux platform |
1 similar comment
|
@swift-ci please test linux platform |
hjyamauchi
requested review from
eeckstein,
jckarter,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@DougGregor Would you take a look? This is a follow-up to the previous #76433. |
|
Thanks! |
|
Oh nice! Merged (hoping it's not too much trouble rebasing that). Thank you! |
|
@eeckstein Actually I'll test eeckstein@f4af4d1 in my local setup and create a PR, if that's okay. |
|
@eeckstein I locally tested and it can build the toolchain as before (no regression.) I created #76675 based on eeckstein@f4af4d1. |
On Windows ARM64, how a struct value type is returned is sensitive to conditions including whether a user-defined constructor exists, etc. See https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#return-values That caused a calling convention mismatch between the non-USED_IN_CPP_SOURCE (Swift) side and the USE_IN_CPP_SOURCE (C++) side and a crash. Following swiftlang#76433 add constructors to several bridged C++ struct/class types so that the calling convention matches. This is a partial fix for swiftlang#74866 Cherrypick swiftlang#76589
On Windows ARM64, how a struct value type is returned is sensitive to conditions including whether a user-defined constructor exists, etc. See https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#return-values That caused a calling convention mismatch between the non-USED_IN_CPP_SOURCE (Swift) side and the USE_IN_CPP_SOURCE (C++) side and a crash. Following swiftlang#76433 add constructors to several bridged C++ struct/class types so that the calling convention matches. This is a partial fix for swiftlang#74866 Cherrypick swiftlang#76589
On Windows ARM64, how a struct value type is returned is sensitive to conditions including whether a user-defined constructor exists, etc. See
https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#return-values
That caused a calling convention mismatch between the non-USED_IN_CPP_SOURCE (Swift) side and the USE_IN_CPP_SOURCE (C++) side and a crash.
Following #76433 add constructors to several bridged C++ struct/class types so that the calling convention matches.
This is a partial fix for #74866