[cmake] Add missing dependency between component and its targets #76596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`swift_install_in_component` does not create a dependency between its `TARGETS` and the `COMPONENT`, so one has to be created manually. The missing dependency might cause invocations to CMake/Ninja for the `install-*` targets to not build the required files before the installation is performed. Because the normal `build-script` builds the `all` target, this kind of missing dependencies like this are common. This bit of code appeared in swiftlang#76497 some days ago.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift_install_in_componentdoes not create a dependency between itsTARGETSand theCOMPONENT, so one has to be created manually. The missing dependency might cause invocations to CMake/Ninja for theinstall-*targets to not build the required files before the installation is performed. Because the normalbuild-scriptbuilds thealltarget, this kind of missing dependencies like this are common.This bit of code appeared in #76497 some days ago.