Skip to content

[concurrency] UnspecifiedMeansMainActorIsolated tests as require asserts #76616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drodriguez
Copy link
Contributor

@drodriguez drodriguez commented Sep 20, 2024

Two test using an experimental feature UnspecifiedMeansMainActorIsolated are not marked as REQUIRES: asserts and are failing when asserts are disabled.

Introduced in #76558

Two test using an experimental feature UnspecifiedMeansMainActorIsolated
are not marking as `REQUIRES: asserts` and are failing when asserts are
disabled.

Introduced in swiftlang#76558
@drodriguez drodriguez requested a review from gottesmm September 20, 2024 20:55
@drodriguez drodriguez requested a review from ktoso as a code owner September 20, 2024 20:55
@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test

@drodriguez drodriguez enabled auto-merge (squash) September 20, 2024 20:56
@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

@drodriguez
Copy link
Contributor Author

@swift-ci please test Linux platform

@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and the fix @drodriguez. Unrelated failures, rerunning the tests.

@ktoso
Copy link
Contributor

ktoso commented Sep 23, 2024

@swift-ci please smoke test Linux

@shahmishal shahmishal disabled auto-merge September 23, 2024 15:56
@shahmishal shahmishal merged commit 4a46b16 into swiftlang:main Sep 23, 2024
2 of 4 checks passed
@drodriguez drodriguez deleted the requires-asserts-assume-mainactor branch September 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants