Sema: Various TypeRefinementContext tree fixes #76621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases. Nodes in the TypeRefinementContext tree should be introduced for enum cases, rather than enum elements, since its the cases that carry availability annotations. Previously, enum cases in source that contained more than one element would result in a malformed TRC tree that had overlapping sibling nodes for each of the elements in a case declaration.
The `TypeRefinementContextBuilder` could visit a given `VarDecl` in the AST multiple times when the `VarDecl` has a parent `PatternBindingDecl`, resulting in duplicate TRC nodes.
tshortli
requested review from
hborla,
slavapestov and
xedin
as code owners
Previously, the root TypeRefinementContext could contain duplicate top level nodes for any source file that had its TRC built on-demand to satisfy type checking requests before that file was explicitly typechecked.
tshortli
force-pushed
the
type-refinement-context-fixes
branch
from
3e6e9a5 to
2f0a22c
Compare
|
@swift-ci please smoke test |
tshortli
changed the title
slavapestov
approved these changes
Sep 21, 2024
|
These fixes actually came out of writing a verifier for the |
|
Awesome! |
|
@swift-ci please smoke test Linux |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Oct 31, 2024
swiftlang#76621 caused a regression by skipping the AST nodes nested under `defer` blocks. The node associated with a `defer` block is implicit because it is a kind of closure context synthesized by the compiler. However, the nodes it contains are not implicit and so they must be visited by the `TypeRefinementContextBuilder`.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Oct 31, 2024
swiftlang#76621 caused a regression by skipping the AST nodes nested under `defer` blocks. The node associated with a `defer` block is implicit because it is a kind of closure context synthesized by the compiler. However, the nodes it contains are not implicit and so they must be visited by the `TypeRefinementContextBuilder`. Resolves rdar://139012152
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Nov 1, 2024
swiftlang#76621 caused a regression by skipping the AST nodes nested under `defer` blocks. The node associated with a `defer` block is implicit because it is a kind of closure context synthesized by the compiler. However, the nodes it contains are not implicit and so they must be visited by the `TypeRefinementContextBuilder`. Resolves rdar://139012152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of ways that the tree produced by
TypeRefinementContextBuildercould be malformed:Fortunately, because the duplicated tree content was always ordered after the canonical child, the malformed trees never resulted in incorrect query results. Building the extra nodes did waste CPU and memory, though.