[IRGen] Reintroduce typed throws ABI #76630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci build toolchain macos |
|
@swift-ci test |
|
@swift-ci smoke test |
|
@swift-ci build toolchain macos |
|
@swift-ci smoke test |
|
@swift-ci build toolchain macos |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test |
drexin
force-pushed
the
wip-135954459
branch
from
712457d to
1ae1460
Compare
|
@swift-ci smoke test |
drexin
force-pushed
the
wip-135954459
branch
from
1ae1460 to
3e76ea2
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
rdar://135954459
LLVM doesn't like undef instances of void. rdar://135631963
When the error is an empty type, the return value for the error case needs to be an `undef` value of the result type, or `void`, if the result type is `void`
The mapping was completely missing, causing compiler crashes.
…bi.swift test Adding some tests cases for direct return of typed errors in synchronous functions.
…syncReturn When the result is empty, but the error type is not, we have to return an `undef` for the result.
For empty errors, we expect `undef` to eb returned
…typed throws function
…esult types When the error type does not directly fit into the result type, we appy a mapping. These tests verify that this mapping is applied properly on the callee and caller site.
…result types When the error type does not directly fit into the result type, we appy a mapping. These tests verify that this mapping is applied properly on the callee and caller site.
…irect error return typed throws
Adding more cases with errors of different sizes
Some types that should have been were not mapped into context.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://135954459