Skip to content

[Mem2Reg] Always bail on dynamic_lifetime. #76656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

[Mem2Reg] Always bail on dynamic_lifetime. #76656

merged 1 commit into from
Sep 24, 2024

Conversation

nate-chandler
Copy link
Contributor

rdar://136388508

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler nate-chandler merged commit b9228c8 into swiftlang:main Sep 24, 2024
5 of 8 checks passed
@nate-chandler nate-chandler deleted the rdar136388508 branch September 24, 2024 14:00
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Sep 26, 2024
@aschwaighofer
Revert "Merge pull request swiftlang#76656 from nate-chandler/rdar136…
8d89517 
…388508"

This reverts commit b9228c8, reversing
changes made to 6fb2989.

After PR#76686 this bailout should no longer be neccessary.

rdar://136681998
aschwaighofer added a commit that referenced this pull request Sep 27, 2024
@aschwaighofer
Merge pull request #76719 from aschwaighofer/revert_pr76656
2947510 
Revert "Merge pull request #76656 from nate-chandler/rdar136388508"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

@meg-gupta meg-gupta meg-gupta approved these changes

@jckarter jckarter Awaiting requested review from jckarter

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nate-chandler @eeckstein @meg-gupta