Add -fine-grained-timers flag #76662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't measure time spent in IRGen in multi-threaded mode previously.
To get timings here, just use -fine-grained-timers.
By default, -stats-output-dir does not collect per-request timers and counters, because of overhead.
Also, if all the stats are zero, raise an error instead of silently succeeding.
slavapestov
requested review from
hborla,
xedin,
jckarter,
rjmccall,
artemcm,
tshortli and
DougGregor
as code owners
|
@swift-ci Please smoke test |
xedin
approved these changes
Sep 24, 2024
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is off, we skip collecting per-request timers, which eliminates most of the overhead of using -stats-output-dir.