[NFC] Refactor PredictableMemoryOptimization #76714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding mark_dependence support. Required to support addressors (unsafeAddress) in places other than UnsafePointer.pointee.
|
@swift-ci test |
|
A validation test running in the simulator appears to have timed out |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding mark_dependence support. Required to support addressors (unsafeAddress) in places other than UnsafePointer.pointee.
This is a literal refactor. It formally separates the load optimizations and dead allocation optimizations, which are actually different algorithms. This obvious refactor will allow each optimization, which is fundamentally different to be naturally extended to handle other kinds of uses, like mark_dependence.
I made no attempt to update the code style. That's not the goal of this PR.