[build] Build sourcekit-lsp for multiple arches and lipo them #76730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please build toolchain |
Instead of building SourceKit-LSP using SwiftPM's multi-arch xcbuild backend, build it for only one arch at a time and then run `lipo` to merge the two resulting binaries. This should allow us to share build products between building installing and testing and also eliminates other quirks resulting from the xcbuild backend.
|
Toolchain builds succeeded. Just fixing Python lint issues now, so won’t run another toolchain build. |
ahoppen
force-pushed
the
ahoppen/lsp-cross-compile
branch
from
44eb5ec to
04e78e0
Compare
|
@swift-ci Please smoke test |
rintaro
reviewed
Sep 30, 2024
| self.source_dir, 'Utilities', 'build-script-helper.py') | ||
|
|
||
| install_destdir = self.host_install_destdir(host_target) | ||
| toolchain_path = self.native_toolchain_path(base_target) |
There was a problem hiding this comment.
base_target parameter is only used for this. I'm not really sure what's the semantics of native_toolchain_path argument. Deferring to @edymtt .
Also, I think
# base_target is the machine that's driving the build.
is only true for Darwin platforms. For other platforms, build/install is called for each host. Should we use self.arg.host_target instead?
etcwilde
approved these changes
Oct 11, 2024
|
Yes, that’s done by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building SourceKit-LSP using SwiftPM's multi-arch xcbuild backend, build it for only one arch at a time and then run
lipoto merge the two resulting binaries.This should allow us to share build products between building installing and testing and also eliminates other quirks resulting from the xcbuild backend.