[Macro] Precise macro plugin dependency during scanning #76732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
adrian-prantl,
xymus,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
Please test with following PR: @swift-ci please smoke test |
|
Please test with following PR: @swift-ci please smoke test |
|
ping |
1 similar comment
|
ping |
|
@rintaro you know the plugin infrastructure better than anyone |
|
@rintaro ping |
Add flag `-load-resolved-plugin` to load macro plugin, which provides a pre-resolved entry into PluginLoader so the plugins can be loaded based on module name without searching the file system. The option is mainly intended to be used by explicitly module build and the flag is supplied by dependency scanner.
Teach dependency scanner to construct build commands using resolved plugin search path option. This ensures the modules that do not have access to the macro plugins will not have a different variant due to different plugin search path. rdar://136682810
cachemeifyoucan
force-pushed
the
eng/PR-136682810
branch
from
cc01e02 to
2d204f8
Compare
|
Please test with following PR: @swift-ci please smoke test |
|
Rebase the change and update the test to test the interaction between new options with the other options. |
|
@rintaro review feedback addressed. |
rintaro
approved these changes
Nov 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach dependency scanner to track precise dependencies for macro plugin:
This also means if a macro plugin search path is not used, it will not cause an additional module variants due to the search path difference.
rdar://136682810