Runtime: Set 'is not bitwise borrowable' bit for raw layout types. #76734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckarter
requested review from
rjmccall,
mikeash and
al45tair
as code owners
|
@swift-ci Please test |
Azoy
reviewed
Sep 26, 2024
| /// | ||
| /// No raw layout types are yet, but should we change our mind about that in the future, | ||
| /// this flag is here. | ||
| BitwiseBorrowable = 0x4, |
There was a problem hiding this comment.
Wouldn't all raw layout types not be bitwise borrowable? Can't we just unconditionally set this to false in the init function?
There was a problem hiding this comment.
I thought that having a flag to allow a raw layout type to be bitwise-borrowable in the future would be good future proofing, should we have a reason to do so later.
mikeash
approved these changes
Sep 27, 2024
| @@ -0,0 +1,41 @@ | |||
| // RUN: %target-run-simple-swift(-enable-experimental-feature RawLayout) | |||
| // REQUIRES: executable_test | |||
| // UNSUPPORTED: use_os_stdlib | |||
There was a problem hiding this comment.
You'll also want // UNSUPPORTED: back_deployment_runtime for the full effect.
include/swift/ABI/Metadata.h
Outdated
| @@ -2221,7 +2221,7 @@ struct TargetExtendedExistentialTypeShape | |||
| bool hasGeneralizationSignature() const { | |||
| return Flags.hasGeneralizationSignature(); | |||
| } | |||
|
|
|||
When initializing metadata for layout-dependent raw layout types, set the "is not bitwise borrowable" bit.
jckarter
force-pushed
the
atomic-layout-runtime
branch
from
11a6f06 to
6e565b5
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing metadata for layout-dependent raw layout types, set the "is not bitwise borrowable" bit.