[Blocklist] Make sure blocklist config is read through VFS #76737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
Make sure block-list file is read through VFS so CASFS can be used to read the configuration to ensure sound caching, and also the path of the blocklist can be canonicalized via path remapping.
Make sure blocklists are remapped for interface compilation. The main module blocklist remap is done by swift-driver and do not need to be handled in scanner.
cachemeifyoucan
force-pushed
the
eng/PR-block-list-vfs
branch
from
e24337d to
7adaf50
Compare
|
@swift-ci please smoke test |
|
Thank you! |
tshortli
approved these changes
Sep 27, 2024
artemcm
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure block-list file is read through VFS so CASFS can be used to read the configuration to ensure sound caching, and also the path of the blocklist can be canonicalized via path remapping.