[ASTPrinter] Restore printing generic requirement contexts #7675
Conversation
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
LGTM! |
|
@swift-ci Please test |
|
Build failed |
|
|
||
| // RUN: %sourcekitd-test -req=cursor -pos=81:8 %s -- -F %S/../Inputs/libIDE-mock-sdk -I %t.tmp %mcp_opt %s | %FileCheck %s -check-prefix=CHECK34 | ||
| // CHECK34: source.lang.swift.decl.function.method.instance (81:8-81:50) | ||
| // CHECK34-NEXT: foo(_:) | ||
| // CHECK34-NEXT: s:FV11cursor_info2S23foou0_Rd_0_zqd__rFFT_T_FT_T_ | ||
| // CHECK34-NEXT: <T, U, V, W where U == T, W == V> (S2<T, U>) -> (() -> ()) -> () -> () |
There was a problem hiding this comment.
Did you mean to delete these other lines? Also in other changes below.
There was a problem hiding this comment.
Nope, I sure didn't. Sigh.
There was a problem hiding this comment.
Ah, this was a conflict resolution when I cherry-picked the original commit. I'll fix it.
|
Build failed |
cfe9e6a removed calls to pre/post printing of PrintStructureKind::GenericRequirement, so SourceKit DocInfo requests started droping the markers for generic requirements, causing some weirdness with documentation rendering and post-processing. Restore the calls to printStructPre/Post when printing generic requirements. rdar://problem/30561880
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
|
Thanks, LGTM! |
|
Build failed |
- Remove a test file that made its way in to the original commit. - Don't need a newline forcing wrapper for printStructurePost rdar://problem/30404063
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@shahmishal, I feel like the bot shouldn't be posting notifications that say "Build failed" for automatically restarted builds due to a different SHA. |
|
(Especially since the build actually successfully starts) |
bitjammer
deleted the
rdar-30561880-missing-constraint-annotation-swift-3.1
branch
cfe9e6a removed calls to pre/post
printing of PrintStructureKind::GenericRequirement, so SourceKit DocInfo
requests started dropping the markers for generic requirements, causing
some weirdness with documentation rendering and post-processing.
Restore the calls to printStructPre/Post when printing generic
requirements.
rdar://problem/30561880