[Concurrency] Drop the cloned code for Embedded around 'any Actor' #76766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
ktoso,
phausler,
rjmccall,
al45tair,
rauhul and
eeckstein
|
@swift-ci please test |
| @@ -184,159 +184,6 @@ public struct DiscardingTaskGroup { | |||
| let _: Void? = try await _taskGroupWaitAll(group: _group, bodyError: nil) | |||
| } | |||
|
|
|||
| // Clone the task-creation routines in Embedded Swift so that we don't | |||
| // introduce an implicit use of `any Actor`. | |||
| #if !$Embedded | |||
There was a problem hiding this comment.
Are you sure that the #if !$Embedded branch is the one to remove? It contains the @isolated(any) additions (introduced by commit a86b76a).
There was a problem hiding this comment.
You're right, thanks! Fixed.
kubamracek
force-pushed
the
embedded-dont-avoid-any-actor
branch
from
074bb55 to
9b56ea0
Compare
|
@swift-ci please test |
ktoso
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Very happy to see some reduction of duplication for a change :) Thank you @kubamracek !
ktoso
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
any Actoris usable in Embedded Swift, we can drop all this ifdef'd code.