Skip to content

Revert "[SILGen] Fix the type of closure thunks that are passed const reference structs" #76774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

slavapestov
Copy link
Contributor

Unfortunately this breaks swift-nio in the source compat suite:

https://ci.swift.org/job/swift-main-source-compat-suite-debug/910/artifact/swift-source-compat-suite/FAIL_swift-nio_5.0_BuildSwiftPackage.log

error: compile command failed due to signal 6 (use -v to see invocation)
Assertion failed: ((!asForeign || thunkType) && "thunk type needed for foreign type for closures"), function SILDeclRef, file SILDeclRef.cpp, line 177.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.	Program arguments: /Users/ec2-user/jenkins/workspace-private/swift-main-source-compat-suite-debug/build/compat_macos/install/toolchain/usr/bin/swift-frontend -frontend -c /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AddressedEnvelopeTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AddressedEnvelopeTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AsyncSequenceTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AsyncSequenceTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AsyncSequences/NIOAsyncSequenceProducer+HighLowWatermarkBackPressureStrategyTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AsyncSequences/NIOAsyncSequenceTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AsyncSequences/NIOAsyncWriterTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/AsyncSequences/NIOThrowingAsyncSequenceTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/BaseObjectsTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/BaseObjectsTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ByteBufferLengthPrefixTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ByteBufferLengthPrefixTests.swift -primary-file /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ByteBufferTest+XCTest.swift -primary-file /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ByteBufferTest.swift -primary-file /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ChannelOptionStorageTest+XCTest.swift -primary-file /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ChannelOptionStorageTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/CircularBufferTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/CircularBufferTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/CustomChannelTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/CustomChannelTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/DispatchQueue+WithFutureTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/DispatchQueue+WithFutureTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/IOErrorTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/IOErrorTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/IntegerTypesTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/IntegerTypesTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/LinuxTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/LinuxTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/MarkedCircularBufferTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/MarkedCircularBufferTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/NIOAnyDebugTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/NIOAnyDebugTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/NIOCloseOnErrorHandlerTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/NIOCloseOnErrorHandlerTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/RecvByteBufAllocatorTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/RecvByteBufAllocatorTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/SingleStepByteToMessageDecoderTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/SingleStepByteToMessageDecoderTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/TimeAmount+DurationTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/TimeAmount+DurationTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/TimeAmountTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/TimeAmountTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/TypeAssistedChannelHandlerTests+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/TypeAssistedChannelHandlerTests.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/UtilitiesTest+XCTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/UtilitiesTest.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/XCTest+AsyncAwait.swift /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/XCTest+Extensions.swift -supplementary-output-file-map /var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/TemporaryDirectory.Jtf6jZ/supplementaryOutputs-4 -target x86_64-apple-macosx13.0 -enable-objc-interop -sdk /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -I /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/Modules -I /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib -F /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -enable-testing -g -debug-info-format=dwarf -dwarf-version=4 -module-cache-path /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/ModuleCache -swift-version 5 -Onone -D SWIFT_PACKAGE -D DEBUG -empty-abi-descriptor -disable-sandbox -Xcc -working-directory -Xcc /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio -resource-dir /Users/ec2-user/jenkins/workspace-private/swift-main-source-compat-suite-debug/build/compat_macos/install/toolchain/usr/lib/swift -enable-anonymous-context-mangled-names -file-compilation-dir /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio -Xcc -fmodule-map-file=/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/checkouts/swift-atomics/Sources/_AtomicsShims/include/module.modulemap -Xcc -I -Xcc /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/checkouts/swift-atomics/Sources/_AtomicsShims/include -Xcc -fmodule-map-file=/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Sources/CNIOWindows/include/module.modulemap -Xcc -I -Xcc /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Sources/CNIOWindows/include -Xcc -fmodule-map-file=/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/CNIOLinux.build/module.modulemap -Xcc -I -Xcc /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Sources/CNIOLinux/include -Xcc -fmodule-map-file=/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/CNIOAtomics.build/module.modulemap -Xcc -I -Xcc /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Sources/CNIOAtomics/include -Xcc -fmodule-map-file=/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/CNIODarwin.build/module.modulemap -Xcc -I -Xcc /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Sources/CNIODarwin/include -Xcc -isysroot -Xcc /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -Xcc -F -Xcc /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -Xcc -fPIC -Xcc -g -module-name NIOCoreTests -in-process-plugin-server-path /Users/ec2-user/jenkins/workspace-private/swift-main-source-compat-suite-debug/build/compat_macos/install/toolchain/usr/lib/swift/host/libSwiftInProcPluginServer.dylib -plugin-path /Users/ec2-user/jenkins/workspace-private/swift-main-source-compat-suite-debug/build/compat_macos/install/toolchain/usr/lib/swift/host/plugins -plugin-path /Users/ec2-user/jenkins/workspace-private/swift-main-source-compat-suite-debug/build/compat_macos/install/toolchain/usr/local/lib/swift/host/plugins -target-sdk-version 14.2 -target-sdk-name macosx14.2 -external-plugin-path /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib/swift/host/plugins#/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/bin/swift-plugin-server -external-plugin-path /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/local/lib/swift/host/plugins#/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/bin/swift-plugin-server -parse-as-library -o /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/NIOCoreTests.build/ByteBufferTest+XCTest.swift.o -o /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/NIOCoreTests.build/ByteBufferTest.swift.o -o /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/NIOCoreTests.build/ChannelOptionStorageTest+XCTest.swift.o -o /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/NIOCoreTests.build/ChannelOptionStorageTest.swift.o -index-store-path /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/.build/x86_64-apple-macosx/debug/index/store -index-system-modules
1.	Apple Swift version 6.1-dev (LLVM 36eb110968adc58, Swift 606641834035f11)
2.	Compiling with effective version 5.10
3.	While evaluating request ASTLoweringRequest(Lowering AST to SIL for file "/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ByteBufferTest.swift")
4.	While silgen emitFunction SIL function "@$s12NIOCoreTests14ByteBufferTestC025testAllocationOfReallyBigcD0yyKF".
 for 'testAllocationOfReallyBigByteBuffer()' (at /Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/swift-nio/Tests/NIOCoreTests/ByteBufferTest.swift:1327:5)
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x00000001099a5ea8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 40
1  swift-frontend           0x00000001099a4048 llvm::sys::RunSignalHandlers() + 248
2  swift-frontend           0x00000001099a650e SignalHandler(int) + 270
3  libsystem_platform.dylib 0x00007ff80e3525ed _sigtramp + 29
4  swift-frontend           0x0000000103323600 $s3SIL8FunctionC8registeryyFZySo07BridgedB0V_SvSitcfU_ + 128
5  libsystem_c.dylib        0x00007ff80e24bb45 abort + 123
6  libsystem_c.dylib        0x00007ff80e24ae5e err + 0
7  swift-frontend           0x0000000109e58473 swift::SILDeclRef::SILDeclRef(llvm::PointerUnion<swift::ValueDecl*, swift::AbstractClosureExpr*, swift::FileUnit*>, bool, bool, bool, clang::Type const*) (.cold.1) + 35
8  swift-frontend           0x000000010451c092 swift::SILDeclRef::SILDeclRef(llvm::PointerUnion<swift::ValueDecl*, swift::AbstractClosureExpr*, swift::FileUnit*>, bool, bool, bool, clang::Type const*) + 434
9  swift-frontend           0x0000000103c6d676 (anonymous namespace)::RValueEmitter::visitFunctionConversionExpr(swift::FunctionConversionExpr*, swift::Lowering::SGFContext) + 3014
10 swift-frontend           0x0000000103c62d14 swift::ASTVisitor<(anonymous namespace)::RValueEmitter, swift::Lowering::RValue, void, void, void, void, void, swift::Lowering::SGFContext>::visit(swift::Expr*, swift::Lowering::SGFContext) + 740
11 swift-frontend           0x0000000103c5847c swift::Lowering::SILGenFunction::emitRValueAsSingleValue(swift::Expr*, swift::Lowering::SGFContext) + 60
12 swift-frontend           0x0000000103bfc66c (anonymous namespace)::ArgEmitter::emit(swift::Lowering::ArgumentSource&&, swift::Lowering::AbstractionPattern, std::__1::optional<swift::AnyFunctionType::Param>) + 4236
13 swift-frontend           0x0000000103be9488 (anonymous namespace)::ArgEmitter::emitSingleArg(swift::Lowering::ArgumentSource&&, swift::Lowering::AbstractionPattern, std::__1::optional<swift::AnyFunctionType::Param>) + 296
14 swift-frontend           0x0000000103bfa905 (anonymous namespace)::ArgEmitter::emitPreparedArgs(swift::Lowering::PreparedArguments&&, swift::Lowering::AbstractionPattern) + 261
15 swift-frontend           0x0000000103c088cc (anonymous namespace)::CallSite::emit(swift::Lowering::SILGenFunction&, swift::Lowering::AbstractionPattern, swift::CanTypeWrapper<swift::SILFunctionType>, (anonymous namespace)::ParamLowering&, llvm::SmallVectorImpl<swift::Lowering::ManagedValue>&, llvm::SmallVectorImpl<(anonymous namespace)::DelayedArgument>&, swift::ForeignInfo const&) && + 1068
16 swift-frontend           0x0000000103c08017 (anonymous namespace)::CallEmission::emitArgumentsForNormalApply(swift::Lowering::AbstractionPattern, swift::CanTypeWrapper<swift::SILFunctionType>, swift::ForeignInfo const&, llvm::SmallVectorImpl<swift::Lowering::ManagedValue>&, std::__1::optional<swift::SILLocation>&) + 1191
17 swift-frontend           0x0000000103bee3a2 (anonymous namespace)::CallEmission::apply(swift::Lowering::SGFContext) + 2178
18 swift-frontend           0x0000000103beb4d3 swift::Lowering::SILGenFunction::emitApplyExpr(swift::ApplyExpr*, swift::Lowering::SGFContext) + 51
19 swift-frontend           0x0000000103c62a79 swift::ASTVisitor<(anonymous namespace)::RValueEmitter, swift::Lowering::RValue, void, void, void, void, void, swift::Lowering::SGFContext>::visit(swift::Expr*, swift::Lowering::SGFContext) + 73
20 swift-frontend           0x0000000103c5521c swift::Lowering::SILGenFunction::emitExprInto(swift::Expr*, swift::Lowering::Initialization*, std::__1::optional<swift::SILLocation>) + 172
21 swift-frontend           0x0000000103c3fe34 swift::Lowering::SILGenFunction::emitPatternBinding(swift::PatternBindingDecl*, unsigned int, bool) + 1700
22 swift-frontend           0x0000000103c47a53 swift::ASTVisitor<swift::Lowering::SILGenFunction, void, void, void, void, void, void>::visit(swift::Decl*) + 147
23 swift-frontend           0x0000000103d06bbc swift::ASTVisitor<(anonymous namespace)::StmtEmitter, void, void, void, void, void, void>::visit(swift::Stmt*) + 5932
24 swift-frontend           0x0000000103d05485 swift::Lowering::SILGenFunction::emitStmt(swift::Stmt*) + 21
25 swift-frontend           0x0000000103c82b97 swift::Lowering::SILGenFunction::emitFunction(swift::FuncDecl*) + 487
26 swift-frontend           0x0000000103bd6cdc swift::Lowering::SILGenModule::emitFunctionDefinition(swift::SILDeclRef, swift::SILFunction*) + 6716
27 swift-frontend           0x0000000103bd7c77 swift::Lowering::SILGenModule::emitOrDelayFunction(swift::SILDeclRef) + 263
28 swift-frontend           0x0000000103bd5278 swift::Lowering::SILGenModule::emitFunction(swift::FuncDecl*) + 184
29 swift-frontend           0x0000000103d1f295 (anonymous namespace)::SILGenType::visitFuncDecl(swift::FuncDecl*) + 21
30 swift-frontend           0x0000000103d1b752 (anonymous namespace)::SILGenType::emitType() + 290
31 swift-frontend           0x0000000103d1b629 swift::Lowering::SILGenModule::visitNominalTypeDecl(swift::NominalTypeDecl*) + 25
32 swift-frontend           0x0000000103bda6e3 swift::Lowering::SILGenModule::emitSourceFile(swift::SourceFile*) + 179
33 swift-frontend           0x0000000103bdacf4 swift::ASTLoweringRequest::evaluate(swift::Evaluator&, swift::ASTLoweringDescriptor) const + 804
34 swift-frontend           0x0000000103d04e73 swift::SimpleRequest<swift::ASTLoweringRequest, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule>> (swift::ASTLoweringDescriptor), (swift::RequestFlags)17>::evaluateRequest(swift::ASTLoweringRequest const&, swift::Evaluator&) + 115
35 swift-frontend           0x0000000103be049d swift::ASTLoweringRequest::OutputType swift::Evaluator::getResultUncached<swift::ASTLoweringRequest, swift::ASTLoweringRequest::OutputType swift::evaluateOrFatal<swift::ASTLoweringRequest>(swift::Evaluator&, swift::ASTLoweringRequest)::'lambda'()>(swift::ASTLoweringRequest const&, swift::ASTLoweringRequest::OutputType swift::evaluateOrFatal<swift::ASTLoweringRequest>(swift::Evaluator&, swift::ASTLoweringRequest)::'lambda'()) + 333
36 swift-frontend           0x0000000103bdb454 swift::performASTLowering(swift::FileUnit&, swift::Lowering::TypeConverter&, swift::SILOptions const&, swift::IRGenOptions const*) + 100
37 swift-frontend           0x00000001034dd4a5 swift::performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 693
38 swift-frontend           0x00000001034ec34f withSemanticAnalysis(swift::CompilerInstance&, swift::FrontendObserver*, llvm::function_ref<bool (swift::CompilerInstance&)>, bool) + 143
39 swift-frontend           0x00000001034df920 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 944
40 swift-frontend           0x00000001034dedfb swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2699
41 swift-frontend           0x0000000103295799 swift::mainEntry(int, char const**) + 2569
42 dyld                     0x00007ff80dfcb41f start + 1903

Reverts #75491

@slavapestov
Copy link
Contributor Author

@ahatanaka Do you mind taking a look?

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov merged commit b24a810 into main Sep 30, 2024
5 checks passed
@slavapestov slavapestov deleted the revert-75491-cxx-const-ref branch September 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant