Skip to content

[Test] Mark additional tests with REQUIRES: asserts for KeyPathWithStaticMembers flag. #76776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Test] Mark additional tests with REQUIRES: asserts for KeyPathWithStaticMembers flag. #76776

merged 1 commit into from
Sep 30, 2024

Conversation

amritpan
Copy link
Member

@amritpan amritpan commented Sep 30, 2024 •
edited
Loading

This adds REQUIRES: asserts to all Sema/SIL tests with the KeyPathWithStaticMembers experimental flag to resolve failures in a noassert build.

@amritpan
Copy link
Member Author

@swift-ci please test

xedin
xedin approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xedin xedin merged commit 3803e91 into swiftlang:main Sep 30, 2024
5 checks passed
@amritpan amritpan deleted the keyPathWithStaticMembers-assert branch September 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amritpan @xedin