-
Notifications
You must be signed in to change notification settings - Fork 10.5k
stdlib: Address a couple of ABI FIXMEs by deleting code #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib: Address a couple of ABI FIXMEs by deleting code #7679
Conversation
@swift-ci Please smoke test |
ae620ef
to
12eb3f1
Compare
@swift-ci Please smoke test |
@nkcsgexi I removed a subscript in this patch, but swift-api-digester did not flag it. Do you mind taking a look? |
@swift-ci Please smoke test |
You are right, the api-digester seems to have trouble digest subscripts. Do you mind file a radar? |
Sure :) |
Looks like that test was checking for the now-removed |
We have an implicit conversion to AnyHashable, so there's no need to have the special subscript on Dictionary at all.
12eb3f1
to
66bcf5b
Compare
@nkcsgexi rdar://30646610 rdar://30646634 |
@swift-ci Please smoke test |
1 similar comment
@swift-ci Please smoke test |
Saw them, thank you! |
@swift-ci Please smoke test Linux |
@ddunbar any ideas what's going on here?
Public CI is hitting the same issue: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/2054/consoleFull#-1082042515fca400bf-2f4a-462e-b517-e058d770b2d7 |
@slavapestov just saw that, a change exposed a problem on 16.04 I need to investigate -- I just reverted for now |
@swift-ci please smoke test linux |
@ddunbar Thank you! |
We have an implicit conversion to AnyHashable, so there's no
need to have the special subscript on Dictionary at all.