Skip to content

stdlib: Address a couple of ABI FIXMEs by deleting code #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

We have an implicit conversion to AnyHashable, so there's no
need to have the special subscript on Dictionary at all.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov force-pushed the any-hashable-stdlib-cleanup branch from ae620ef to 12eb3f1 Compare February 22, 2017 01:53
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@nkcsgexi I removed a subscript in this patch, but swift-api-digester did not flag it. Do you mind taking a look?

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@nkcsgexi
Copy link
Contributor

You are right, the api-digester seems to have trouble digest subscripts. Do you mind file a radar?

@slavapestov
Copy link
Contributor Author

Sure :)

@DougGregor
Copy link
Member

Looks like that test was checking for the now-removed _Hashable protocol

We have an implicit conversion to AnyHashable, so there's no
need to have the special subscript on Dictionary at all.
@slavapestov slavapestov force-pushed the any-hashable-stdlib-cleanup branch from 12eb3f1 to 66bcf5b Compare February 22, 2017 04:29
@slavapestov
Copy link
Contributor Author

@nkcsgexi rdar://30646610 rdar://30646634

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

1 similar comment
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@nkcsgexi
Copy link
Contributor

Saw them, thank you!

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@slavapestov
Copy link
Contributor Author

@ddunbar any ideas what's going on here?

******************** TEST 'llbuild-unit :: BuildSystem/BuildSystemTests/BuildSystemTaskTests.directorySignature' FAILED ********************
Note: Google Test filter = BuildSystemTaskTests.directorySignature
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BuildSystemTaskTests
[ RUN      ] BuildSystemTaskTests.directorySignature
/home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llbuild/unittests/BuildSystem/BuildSystemTaskTests.cpp:167: Failure
Value of: resultA->toData() != resultB->toData()
  Actual: false
Expected: true
[  FAILED  ] BuildSystemTaskTests.directorySignature (3 ms)
[----------] 1 test from BuildSystemTaskTests (3 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (4 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] BuildSystemTaskTests.directorySignature

 1 FAILED TEST

Public CI is hitting the same issue: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/2054/consoleFull#-1082042515fca400bf-2f4a-462e-b517-e058d770b2d7

@ddunbar
Copy link
Contributor

ddunbar commented Feb 22, 2017

@slavapestov just saw that, a change exposed a problem on 16.04 I need to investigate -- I just reverted for now

@ddunbar
Copy link
Contributor

ddunbar commented Feb 22, 2017

@swift-ci please smoke test linux

@slavapestov
Copy link
Contributor Author

@ddunbar Thank you!

@slavapestov slavapestov merged commit c080be7 into swiftlang:master Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants