Skip to content

[Concurrency] Downgrade the isolated default argument error to a warning when the argument expression is @preconcurrency. #76795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

hborla
Copy link
Member

@hborla hborla commented Oct 1, 2024

If the isolation of a default argument expression is @preconcurrency, then the isolation mismatch diagnostic should be downgraded to a warning in Swift 5 mode with complete concurrency checking enabled. I observed this bug while migrating some code to Swift 6 by first enabling warnings via complete concurrency checking.

…ing when the

isolation of the argument expression is `@preconcurrency`.
@hborla
Copy link
Member Author

hborla commented Oct 1, 2024

@swift-ci please smoke test

1 similar comment
@hborla
Copy link
Member Author

hborla commented Oct 1, 2024

@swift-ci please smoke test

@hborla
Copy link
Member Author

hborla commented Oct 2, 2024

@swift-ci please smoke test Linux

@hborla hborla merged commit cab765e into swiftlang:main Oct 2, 2024
3 checks passed
@hborla hborla deleted the isolated-default-value-downgrade branch October 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant