-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Test] Remove abi tests descriptors for KeyPathWithStaticMembers flag. #76826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xedin I'm unable to reproduce this locally so I've relied on the failure output shared on the original PR. |
@swift-ci please test |
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Oct 3, 2024
Originally added in swiftlang#73242. swiftlang#76826 was up to remove them but we took swiftlang#76824 instead. Resolves rdar://136918801.
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Oct 3, 2024
Originally added in swiftlang#73242. swiftlang#76826 was up to remove them but we took swiftlang#76824 instead. Resolves rdar://136918801.
2415c4b
to
cf48234
Compare
@swift-ci please test |
@swift-ci please build toolchain macOS platform |
@swift-ci please build toolchain macOS |
xedin
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes property descriptors in abi tests that are being removed with the KeyPathWithStaticMembers flag and causing this failure in the swift macOS toolchain for builds with asserts.