Skip to content

[Test] Remove abi tests descriptors for KeyPathWithStaticMembers flag. #76826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

amritpan
Copy link
Member

@amritpan amritpan commented Oct 2, 2024

This removes property descriptors in abi tests that are being removed with the KeyPathWithStaticMembers flag and causing this failure in the swift macOS toolchain for builds with asserts.

@amritpan amritpan requested a review from a team as a code owner October 2, 2024 17:09
@amritpan amritpan requested a review from xedin October 2, 2024 17:09
@amritpan
Copy link
Member Author

amritpan commented Oct 2, 2024

@xedin I'm unable to reproduce this locally so I've relied on the failure output shared on the original PR.

@amritpan
Copy link
Member Author

amritpan commented Oct 2, 2024

@swift-ci please test

@amritpan amritpan closed this Oct 2, 2024
@amritpan amritpan deleted the keyPathWithStaticMembers-abi branch October 2, 2024 19:12
bnbarham added a commit to bnbarham/swift that referenced this pull request Oct 3, 2024
Originally added in swiftlang#73242.
swiftlang#76826 was up to remove them but
we took swiftlang#76824 instead.

Resolves rdar://136918801.
bnbarham added a commit to bnbarham/swift that referenced this pull request Oct 3, 2024
Originally added in swiftlang#73242.
swiftlang#76826 was up to remove them but
we took swiftlang#76824 instead.

Resolves rdar://136918801.
@amritpan amritpan restored the keyPathWithStaticMembers-abi branch October 4, 2024 01:29
@amritpan amritpan reopened this Oct 4, 2024
@amritpan amritpan force-pushed the keyPathWithStaticMembers-abi branch from 2415c4b to cf48234 Compare October 4, 2024 02:49
@amritpan
Copy link
Member Author

amritpan commented Oct 4, 2024

@swift-ci please test

@amritpan
Copy link
Member Author

amritpan commented Oct 4, 2024

@swift-ci please build toolchain macOS platform

@amritpan
Copy link
Member Author

amritpan commented Oct 4, 2024

@swift-ci please build toolchain macOS

@amritpan amritpan merged commit fef61ea into swiftlang:main Oct 4, 2024
6 checks passed
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@amritpan amritpan deleted the keyPathWithStaticMembers-abi branch October 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants