[CAS] Make CAS plugin options to be cache invariant #76835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add CAS configurations into cache key computation. This ensure if the cache keys are identical if two functionally equivalent plugins are used. This is safe to do because if any of the CAS configurations changes how the cache key is computed, they are going to be directly reflected in the cache key without adding its configuration into the key. rdar://137091843
|
@swift-ci please smoke test |
benlangmuir
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add CAS configurations into cache key computation. This ensure if the cache keys are identical if two functionally equivalent plugins are used. This is safe to do because if any of the CAS configurations changes how the cache key is computed, they are going to be directly reflected in the cache key without adding its configuration into the key.
rdar://137091843