Embedded: specialized witness tables, part2: support remaining cases of class existentials #76874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
jckarter,
rjmccall,
hborla and
xedin
as code owners
|
@swift-ci test |
…added to MandatoryPerformanceOptimization's worklist Do it by passing a closure instead of returning the new witness table. This allows to add more than one new witness table to the worklist
For example:
```
protocol Base: AnyObject {}
protocol Derived: Base {}
class C: Derived {}
let e: Derived = C()
```
…ionMap) -> Type` API
…ctions The type needs to be mapped.
In Embedded Swift, witness method lookup is done from specialized witness tables. For this to work, the type of witness_method must be specialized as well. Otherwise the method call would be done with wrong parameter conventions (indirect instead of direct).
…le entries Associated-type entries are simply skipped. Associated-conformance entries point to the specialized conformance witness tables.
…ions In Embedded Swift, witness method lookup is done from specialized witness tables. For this to work, the type of witness_method must be specialized as well. Otherwise the method call would be done with wrong parameter conventions (indirect instead of direct).
…ntries when specializing witness-tables Support associated-type and associated-conformance entries. This enable existentials with associated types.
eeckstein
force-pushed
the
witnesstable-specialization2
branch
from
7beae5a to
f769080
Compare
|
@swift-ci test |
That means: derived classes where the base conforms to a protocol
eeckstein
force-pushed
the
witnesstable-specialization2
branch
from
f769080 to
a3e6e86
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of #76669
This PR adds support for
rdar://135311381