AST: Sort TypeRefinementContexts for better lookup performance #76912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `rangeContainsTokenLocWithGeneratedSource()` utility pre-dated `SourceManager::containsTokenLoc()`.
Improve the performance of looking up the most refined `TypeRefinementContext` for a given source location by storing children in sorted order and using a binary search to query each layer of the tree. This slightly pessimizes insertion (primarily when macros are expanded out of source location order) but lookup is a far more common operation.
Verify the integrity of the tree formed by `TypeRefinementContext` nodes. In general, parent nodes should "contain" their children and children always be in sorted order.
When printing the source ranges for nodes that represent an expansion within a source file, print the range from the original source file and include a description of the kind of expansion.
tshortli
requested review from
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS |
DougGregor
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of querying the
TypeRefinementContexttree to look up the most refined context that contains a source location. By storing the child nodes of a parent context in sorted order, we can search for the child with a source range that contains the target location using a binary search.To ensure the new sorted children invariant is preserved, the
ASTVerifierhas been extended to also verify theTypeRefinementContexthierarchy.