Serialize and Deserialize Debug Scopes #76934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usama54321
requested review from
kubamracek,
nkcsgexi,
eeckstein and
adrian-prantl
usama54321
commented
Oct 9, 2024
usama54321
commented
Oct 9, 2024
eeckstein
reviewed
Oct 11, 2024
usama54321
commented
Oct 15, 2024
|
@swift-ci test |
usama54321
force-pushed
the
usama54321/debug-scope-serialization
branch
2 times, most recently
from
798881e to
2d1a948
Compare
usama54321
requested review from
xymus,
jckarter,
artemcm and
tshortli
as code owners
|
@swift-ci test |
usama54321
changed the title
usama54321
commented
Oct 16, 2024
eeckstein
reviewed
Oct 17, 2024
usama54321
force-pushed
the
usama54321/debug-scope-serialization
branch
from
2d1a948 to
0edb969
Compare
usama54321
commented
Oct 17, 2024
| def experimental_serialize_debug_info: | ||
| Flag<["-"], "experimental-serialize-debug-info">, | ||
| Flags<[FrontendOption, HelpHidden]>, | ||
| HelpText<"Enables seriailzation/deserialization of debug scopes">; |
There was a problem hiding this comment.
This should become on by default eventually, right?
There was a problem hiding this comment.
Yes it should be. I am not sure if we want to turn it on right now. @kubamracek Do you have a suggestion here? Thanks
There was a problem hiding this comment.
Yeah, I think this is a staging flag, correct? Sounds like a good approach to me.
|
@swift-ci test |
|
@swift-ci please test windows platform |
|
@swift-ci please test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
adrian-prantl
approved these changes
Oct 28, 2024
usama54321
commented
Oct 28, 2024
| // ii) Deserialized by linker/optimizer -> deserialized for debugging -> | ||
| // no zombie created | ||
|
|
||
| if (fn->isZombie() && !forDebugScope) { |
There was a problem hiding this comment.
@eeckstein I hope you can take a look at this again. Thanks
This patch adds code for serializing and deserializing debug scopes. During serialization, declarations of functions only referred to by debug scopes are serialization. During deserialization, these declarations are deserialized as zombie functions. The deserializer refuses to deserialize these functions when referred to by the optimizer, such as during Generic Specialization.
deserialized from stdlib
This reverts commit 384877f.
usama54321
force-pushed
the
usama54321/debug-scope-serialization
branch
from
599cac2 to
f3ae48b
Compare
|
@swift-ci test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize functions referred only from debug scopes as zombies. Serialize rest of the functions normally.
While deserializing, if isDebug (deserializing for debug scopes) only deserialize the declaration as zombie and mark function as private/shared since public functions make into the final binary causing linking errors.
If function is later referred to in non debug scope context and the function was not marked a zombie while serializing, resurrect the function, deserialize body if applicable and return it.
While serializing instructions, whenever the debug scopes of the instruction changes, the new scope along with parents is serialized in post order.