Teach check-incremental about -emit-empty-object-file (which disables incremental LLVM codegen, so don't check timestamps if present) #76941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
approved these changes
Oct 10, 2024
|
Do we know what's the underlying problem? |
My understanding is this: The incremental "avoid re-generating a .o file if the IR is the same" logic is based on a magic global in a magic section (__LLVM,__swift_modhash) and in the -emit-empty-object-file mode we just don't generate this symbol (because that would make the IR module non-empty). |
… incremental LLVM codegen, so don't check timestamps if present)
kubamracek
force-pushed
the
embedded-concurrency-no-incremental
branch
from
ba995dd to
2e4e196
Compare
kubamracek
changed the title
|
Changed the approach here a bit: Instead, check-incremental now knows about the -emit-empty-object-file flag. Result should be equivalent to the previous approach. |
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve this ongoing CI build failure: https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator/6524/
...where we are failing a build incrementality check. Given that the embedded _Concurrency.o is an empty object file, it seems like the simplest solution is to just silence the incremental check via
-Xfrontend -disable-incremental-llvm-codegen.