[Diagnostics] Improve warning suggestion for var in for loop
#76946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Oct 15, 2024
pwongxy
force-pushed
the
diag-warn-on-for-var-loop
branch
from
7fdc849 to
7e2b220
Compare
pwongxy
force-pushed
the
diag-warn-on-for-var-loop
branch
from
7e2b220 to
70e7c3c
Compare
xedin
reviewed
Dec 9, 2024
When iterator consists of tuple of variable and iteration only mutates the tuple partially, improve the warning message from "changing to 'let" to "changing the pattern to '(..., case let, ...)"
pwongxy
force-pushed
the
diag-warn-on-for-var-loop
branch
from
70e7c3c to
c1473e8
Compare
xedin
approved these changes
Dec 10, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterator consists of tuple of variable and iteration only mutates the tuple partially, improve the warning message from "changing to 'let" to "changing to 'case let'"
Resolves #72811