[swift-3.1-branch][SDK] Turn URLError.Code back into an enum #7695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`URLError.Code` was missing 2 cases, and had 3 more cases implemented as static properties that would crash when accessed. Due to a limitation in the build process, we can't add availability attributes for enum variants past macOS 10.9. This means 4 of the 5 cases are missing availability attributes that they should have.
|
@swift-ci Please test |
DougGregor
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR reverts #7650 and instead just fixes the missing/broken case.
Unfortunately we can't use availability attributes on 4 of the 5 cases, because apparently the build fails if any enum variant is declared that isn't available on macOS 10.9.
Scope
This fixes the accidental source breakage from #7650. Adding the new variants is technically source-breaking for any code that has an exhaustive switch over cases, but such code is broken anyway and we can't just omit error codes.
SR Issue
Resolves SR-4035.
Risk
Low.
Testing
Nothing beyond the pre-existing tests for
URLError.