Skip to content

[CSBindings] Adjust hasConversions to handle Void has having not … #76952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 10, 2024

…conversions

Tuples in general do have conversions but an empty tuple or Void doesn't, which means that if a type variable has a subtype binding to Void it should be safe to prioritize.

…conversions

Tuples in general do have conversions but an empty tuple or `Void`
doesn't, which means that if a type variable has a subtype binding
to `Void` it should be safe to prioritize.
@xedin xedin requested a review from hborla as a code owner October 10, 2024 14:42
@xedin xedin requested review from slavapestov and removed request for hborla October 10, 2024 14:42
@xedin
Copy link
Contributor Author

xedin commented Oct 10, 2024

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Oct 11, 2024

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Oct 14, 2024

@swift-ci please smoke test

@xedin xedin merged commit f6a0f55 into swiftlang:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant