IDE: Fix my own lazyness in SynthesizedExtensionAnalyzer::Implementation::isApplicable() #76955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
slavapestov
force-pushed
the
fix-issue-76561
branch
from
eef40e8 to
dfe3d49
Compare
|
Still needs tests |
slavapestov
force-pushed
the
fix-issue-76561
branch
from
dfe3d49 to
94938d8
Compare
…ion::isApplicable() This routine was never properly updated to handle layout requirements, conditional conformances, or parameter packs. Let's clear out the FIXMEs and do things properly here. Fixes swiftlang#76561
slavapestov
force-pushed
the
fix-issue-76561
branch
from
94938d8 to
f751d50
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76561