Skip to content

Mitigate the code size increase from eager-lazy array bridging by marking some methods release none #76966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Mitigate the code size increase from eager-lazy array bridging by marking some methods release none #76966

merged 1 commit into from
Oct 11, 2024

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Oct 10, 2024 •
edited
Loading

Fixes rdar://137709108

@Catfish-Man
rdar://137709108 (Mitigate the code size increase from eager-lazy arr…
68e326d 
…ay bridging by marking some methods release none)
@Catfish-Man Catfish-Man self-assigned this Oct 10, 2024
@Catfish-Man Catfish-Man requested a review from a team as a code owner October 10, 2024 22:07
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author 

------- Code size: -O -------

IMPROVEMENT            OLD     NEW     DELTA   RATIO  
ClassArrayGetter.o     3893    3549    -8.8%   **1.10x**
ArrayRemoveAll.o       7369    7097    -3.7%   **1.04x**
NopDeinit.o            4205    4093    -2.7%   **1.03x**
ArrayOfGenericRef.o    8452    8324    -1.5%   **1.02x**
COWTree.o              11045   10885   -1.4%   **1.01x**
ArrayOfRef.o           7819    7707    -1.4%   **1.01x**
DictionaryGroup.o      11875   11747   -1.1%   **1.01x**
SortLettersInPlace.o   8238    8153    -1.0%   **1.01x**

@Catfish-Man Catfish-Man merged commit bca125c into main Oct 11, 2024
6 checks passed
@Catfish-Man Catfish-Man deleted the i-solemnly-swear-count-doesnt-release-anything branch October 11, 2024 06:29
j-hui pushed a commit to j-hui/swift that referenced this pull request Oct 29, 2024
@Catfish-Man @j-hui
rdar://137709108 (Mitigate the code size increase from eager-lazy arr…
af4b624 
…ay bridging by marking some methods release none) (swiftlang#76966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glessard glessard glessard approved these changes

Assignees

@Catfish-Man Catfish-Man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Catfish-Man @glessard