[Build] Make sure we declare LINUX_STATIC dependencies on Musl. #76980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everywhere there's a `SWIFT_MODULE_DEPENDS_LINUX Glibc`, there should be a corresponding `SWIFT_MODULE_DEPENDS_LINUX_STATIC Musl`. This usually won't bite us, depending on build order and parallelism, but I hit one of these yesterday so went looking to see if there were any others. rdar://136208589
|
Explanation: There are missing dependencies that make the Swift Static SDK build unreliable (because sometimes it might try to build something without having built the Musl module yet, which results in strange errors about missing types or functions). |
|
This is a cherry pick of #76977 |
|
@swift-ci Please test |
DougGregor
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everywhere there's a
SWIFT_MODULE_DEPENDS_LINUX Glibc, there should be a correspondingSWIFT_MODULE_DEPENDS_LINUX_STATIC Musl.This usually won't bite us, depending on build order and parallelism, but I hit one of these yesterday so went looking to see if there were any others.
rdar://136208589