[Parse/Sema] Move OptionalEvaluationExpr wrapping to PreCheckTarget #76981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
hamishknight
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci please test source compatibility |
This simplify the Parser diagnostics and some type checker logic.
This comment was marked as resolved.
This comment was marked as resolved.
rintaro
force-pushed
the
precheck-optional-eval-expr
branch
2 times, most recently
from
421e923 to
8e8e4d0
Compare
|
@swift-ci Please smoke test |
|
Test only force-pushed. Compat-suite are running |
rintaro
commented
Oct 11, 2024
| // expected-note@-2 {{found candidate with type '(Int.Type) -> Dictionary<Int, String>.SubSequence' (aka '(Int.Type) -> Slice<Dictionary<Int, String>>')}} | ||
| // expected-note@-3 {{to match this opening '['}} | ||
| // expected-error@-1 {{cannot convert value of type 'Int.Type' to expected argument type 'Int'}} | ||
| // expected-note@-2 {{to match this opening '['}} |
There was a problem hiding this comment.
This is because previously the parser didn't wrap the expression with OptionalEvaluationExpr if it has an parse error.
But a part of optional chain.
rintaro
force-pushed
the
precheck-optional-eval-expr
branch
from
d650917 to
ffeaa71
Compare
|
@swift-ci Please smoke test |
|
@swift-ci please test source compatibility |
hamishknight
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplify the Parser logic and some type checker logic.