[Sema] Fix an issue with the ordering of effects checking and actor isolation checking. #76988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effects checking for `async` requires actor isolation to have been computed. This change removes effects checking out of the contextualize initializers request, because effects checking isn't needed for secondary files. Instead, effects checking is done in the primary decl checker after actor isolation checking.
required isolation of a default value expression.
|
@swift-ci please smoke test |
…ctor isolation inference boundary.
AnthonyLatsis
approved these changes
Oct 12, 2024
ktoso
approved these changes
Oct 12, 2024
|
@swift-ci please smoke test |
hborla
force-pushed
the
init-checking-order
branch
from
85dd518 to
e1bf198
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects checking for
asyncneeds actor isolation to have been computed, but currently effects checking happens first for initializers expressions. This change moves effects checking for initializer expressions to the primary decl checker, after the actor isolation checker runs. This change also fixes an issue where the actor isolation checker would walk into the bodies ofsendingclosures when computing the required isolation of a default initializer expression.Resolves: #73892