[cxx-interop] Add UnsafeCxxContiguousIterator & UnsafeCxxMutableContiguousIterator protocols
#77006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
zoecarver,
hyp,
Xazax-hun,
rjmccall,
beccadax,
ian-twilightcoder,
hborla,
slavapestov and
xedin
as code owners
egorzhdan
force-pushed
the
egorzhdan/cxx-contiguous
branch
from
cbd533d to
49eb805
Compare
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Oct 14, 2024
egorzhdan
force-pushed
the
egorzhdan/cxx-contiguous
branch
from
49eb805 to
046d1ad
Compare
egorzhdan
commented
Oct 14, 2024
| @@ -916,62 +1147,6 @@ struct InputOutputConstIterator { | |||
| } | |||
| }; | |||
|
|
|||
| struct MutableRACIterator { | |||
There was a problem hiding this comment.
(had to move this elsewhere in the file with no source changes)
egorzhdan
force-pushed
the
egorzhdan/cxx-contiguous
branch
from
046d1ad to
855cfba
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-contiguous
branch
from
855cfba to
2439be9
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-contiguous
branch
from
2439be9 to
0755e24
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain Ubuntu 22.04 |
|
@swift-ci Please Build Toolchain Amazon Linux 2 |
|
@swift-ci Please Build Toolchain Debian 12 |
|
@swift-ci Please Build Toolchain Fedora 39 |
…ntiguousIterator` protocols This adds a pair of Swift protocols that represents C++ iterator types conforming to `std::contiguous_iterator_tag` requirements. These are random access iterators that guarantee that the values are stored in consequent memory addresses. This will be used to optimize usage of C++ containers such as `std::vector` from Swift, for instance, by providing an overload of `withContiguousStorageIfAvailable` for contiguous containers. rdar://137877849
egorzhdan
force-pushed
the
egorzhdan/cxx-contiguous
branch
from
0755e24 to
3a200de
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain Amazon Linux 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pair of Swift protocols that represents C++ iterator types conforming to
std::contiguous_iterator_tagrequirements. These are random access iterators that guarantee that the values are stored in consequent memory addresses.This will be used to optimize usage of C++ containers such as
std::vectorfrom Swift, for instance, by providing an overload ofwithContiguousStorageIfAvailablefor contiguous containers.rdar://137877849