[build] Do not implicitly bump macCatalyst deployment target #77024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes linker warnings that look like this: ``` ld: warning: object file (libswiftCompatibility56.a) was built for newer 'macOS' version (XYZ) than being linked (ABC) ``` These were caused by the compatibility binary being incorrectly built with a newer `-target` than desired: the CMake logic was overriding the requested minimum macOS deployment version (10.9) with a much newer macOS SDK version. rdar://137565964
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test macOS |
ktoso
approved these changes
Oct 15, 2024
|
@swift-ci please test macOS |
DougGregor
approved these changes
Oct 18, 2024
|
Landing this now, but I'm happy to address any more feedback post-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes linker warnings that look like this:
These were caused by the compatibility binary being incorrectly built with a newer
-targetthan desired: the CMake logic was overriding the requested minimum macOS deployment version (10.9) with a much newer macOS SDK version.rdar://137565964