Skip to content

[NFC] [Package CMO] Move shouldSerialize into canSerializeFunction #77054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Oct 16, 2024

Remove redundant checks and consolidate serializability logic into one.

Ref rdar://138061004

Remove redundant checks and consolidate serializability logic into one.
@elsh elsh requested a review from eeckstein as a code owner October 16, 2024 19:07
@elsh elsh changed the title [Package CMO] Move shouldSerialize into canSerializeFunction [NFC] [Package CMO] Move shouldSerialize into canSerializeFunction Oct 16, 2024
@elsh
Copy link
Contributor Author

elsh commented Oct 16, 2024

@swift-ci smoke test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring LGTM!

@elsh elsh enabled auto-merge October 16, 2024 20:51
@elsh elsh merged commit e362264 into main Oct 16, 2024
3 checks passed
@elsh elsh deleted the elsh/pcmo-merge-funcs branch October 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants