Skip to content

[IRGen] Properly handle ObjC class existentials in CVW generation #77060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Oct 16, 2024

rdar://13807464

For most TypeInfo based layouts, we don't have enough information to emit CVW, but for ObjC class existentials it's trivial.

Merge after #77056

…ayload enums

rdar://137954177

There was a missing condition in the branch that caused the compiler to try to emit a single payload enum compact value witness for multi payload enums, when the multi payload enum contained an incompatible case.
@drexin drexin requested a review from rjmccall as a code owner October 16, 2024 23:51
@drexin
Copy link
Contributor Author

drexin commented Oct 16, 2024

@swift-ci smoke test

rdar://13807464

For most TypeInfo based layouts, we don't have enough information to emit CVW, but for ObjC class existentials it's trivial.
@drexin
Copy link
Contributor Author

drexin commented Oct 17, 2024

@swift-ci smoke test

@drexin drexin merged commit 95e0a79 into swiftlang:main Oct 17, 2024
3 checks passed
@drexin drexin deleted the wip-138074648 branch October 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant