[IDE] Pass LangOptions to ide::isSourceInputComplete
#77072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro and
artemcm
as code owners
hamishknight
changed the title
ide::isSourceInputCompleteide::isSourceInputComplete
`swift-indent` has already been removed, this code is unused.
Providing these is a bit of a layering violation, the parser shouldn't care about these options (there does seem to be one current use of `TypeCheckerOpts` in the parser for designated operator types, but that's a legacy feature that was never officially supported).
Ensure we account for things like the enablement of bare slash regex literals.
hamishknight
force-pushed
the
complete-options
branch
from
426f138 to
b840730
Compare
ahoppen
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Unrelated change that made it into the PR?
There was a problem hiding this comment.
It's something I happened to notice when changing ParserUnit, I could put it in a separate PR, but then I'd have to rebase one of them.
rintaro
approved these changes
Oct 25, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we account for things like the enablement of bare slash regex literals.
Resolves swiftlang/llvm-project#9430