Skip to content

Re-enable: [PackageCMO] Use InstructionVisitor to check inst serializability. #77108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Oct 18, 2024

This reverts commit 056d447 and fixes bugs.

rdar://138881697

@elsh elsh requested a review from eeckstein as a code owner October 18, 2024 19:59
@elsh
Copy link
Contributor Author

elsh commented Oct 18, 2024

@swift-ci test

@eeckstein
Copy link
Contributor

What did you change compared to the original PR to fix the problem (the reason for the revert)?

@elsh
Copy link
Contributor Author

elsh commented Oct 21, 2024

What did you change compared to the original PR to fix the problem (the reason for the revert)?

I haven't changed anything yet except for the revert, but the CI is passing, which is unexpected.

@elsh
Copy link
Contributor Author

elsh commented Oct 28, 2024

@swift-ci test

@elsh elsh changed the title [Draft] Re-enable: [PackageCMO] Use InstructionVisitor to check inst serializability. Re-enable: [PackageCMO] Use InstructionVisitor to check inst serializability. Oct 28, 2024
@elsh elsh force-pushed the elsh/re-enable-pcmo-refactor branch from af699c3 to 8a3ba47 Compare October 29, 2024 00:24
@elsh
Copy link
Contributor Author

elsh commented Oct 29, 2024

@swift-ci test

@elsh elsh force-pushed the elsh/re-enable-pcmo-refactor branch from 8a3ba47 to 60f0eac Compare October 29, 2024 19:28
@elsh
Copy link
Contributor Author

elsh commented Oct 29, 2024

@swift-ci test

@elsh elsh enabled auto-merge October 30, 2024 00:55
@elsh elsh merged commit cb545ed into main Oct 30, 2024
4 of 5 checks passed
@elsh elsh deleted the elsh/re-enable-pcmo-refactor branch October 30, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants