Skip to content

Tests: Remove -disable-availability-checking in variadic generics tests #77135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

Use the %target-swift-5.9-abi-triple substitution to compile the tests for deployment to the minimum OS versions required for the APIs used in the tests, instead of disabling availability checking.

@tshortli tshortli force-pushed the reenable-availability-checking-generics branch from 7b906cc to cfdd7e3 Compare October 20, 2024 22:35
@tshortli tshortli force-pushed the reenable-availability-checking-generics branch from cfdd7e3 to f827e7c Compare October 20, 2024 22:37
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli
Copy link
Contributor Author

@swift-ci please test macOS

1 similar comment
@shahmishal
Copy link
Member

@swift-ci please test macOS

@tshortli
Copy link
Contributor Author

@swift-ci please test Windows

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!

@tshortli tshortli merged commit 4db04f9 into swiftlang:main Oct 21, 2024
5 checks passed
@tshortli tshortli deleted the reenable-availability-checking-generics branch October 21, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants