Completely refactor class constructor initialization for ownership #7714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a formal access borrow instead of a full borrow to make sure that the borrow ends at the end of the lvalue formal evaluation. rdar://29791263
…make calling designated/chaining initializes use proper ownership. rdar://29791263
…itSelfUses into its own function. The new function is called collectDelegatingClassInitSelfLoadUses. This is just a classical loop function extraction refactor.
As a bonus, now DI properly errors on: super.init(self)
|
Oh and I updated DI as well and fixed some DI bugs. DI before this wasn't triggering on: super.init(self) I found this by noticing that I started to cause this case to trigger in an unrelated SILOptimizer file. I moved the test case to definite init diagnostics and now we check for this error. So it shouldn't break again. |
|
@swift-ci Please smoke test and merge |
gottesmm
deleted the
completely_refactor_class_constructor_initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a product of my blood sweet and tears... but it has been completed. It is the beginning of a chain commits I am hoping to drop late rtoday.
It does the following:
a. It did not use cleanups and if you used cleanups that were expecting to occur in the top level context, the code just asserted.
b. It did not use ownership at all.
c. The designated initializer sequence code was a huge hack that did not use ownership and ad-hoced borrowed things. I replaced this with an open coded solution that is at least principled with usage of cleanups, etc.
rdar://29791263