AST: Refactor AvailabilityContext into a value type #77144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
changed the title
Make the pointer to uniqued storage an implementation detail of an `AvailabilityContext` value. This way clients of `AvailabilityContext` don't need to think about pointers and can have access to mutating operations on a context when appropriate.
tshortli
force-pushed
the
expand-availability-context
branch
from
60699c5 to
b346385
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the pointer to uniqued storage an implementation detail of an
AvailabilityContextvalue. This way clients ofAvailabilityContextdon't need to think about pointers and can have access to mutating operations on a context when appropriate. Also, expandAvailabilityContextto cover platform unavailability and deprecation in addition to platform introduction. This will allowExportContextto adoptAvailabilityContext.