RemoteInspection: Append ResumeAsyncContext field to AsyncTaskInfo #77167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeash
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Looks good. Please feel free to add anything else like this that you need.
We should probably add things to the C interface as well, but that's harder since we don't want to break the ABI. Not sure what the best approach is there, we can add a swift_reflection_asyncTaskInfo2 with the new stuff, but that could grow a lot of variations. Anyway, not something you need to figure out here, just sort of thinking out loud.
kastiglione
force-pushed
the
dl/main/RemoteInspection-Append-ResumeAsyncContext-field-to-AsyncTaskInfo
branch
from
1ad9380 to
e613e1a
Compare
kastiglione
requested review from
a team,
hborla,
slavapestov,
xedin,
eeckstein,
rjmccall,
ahoppen,
bnbarham,
rintaro,
hamishknight,
shahmishal,
CodaFi,
DougGregor,
artemcm,
tshortli,
adrian-prantl,
AnthonyLatsis,
QuietMisdreavus,
xymus,
kavon,
jckarter,
zoecarver,
hyp,
egorzhdan and
Xazax-hun
as code owners
kastiglione
requested review from
mikeash
and removed request for
ahoppen,
bnbarham,
rintaro,
hamishknight,
shahmishal,
CodaFi,
DougGregor,
artemcm,
AnthonyLatsis,
xymus,
kavon,
jckarter,
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
ktoso,
nkcsgexi,
MaxDesiatov,
etcwilde,
beccadax and
ian-twilightcoder
al45tair
approved these changes
Dec 30, 2024
adrian-prantl
approved these changes
Jan 14, 2025
adrian-prantl
deleted the
dl/main/RemoteInspection-Append-ResumeAsyncContext-field-to-AsyncTaskInfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a
Task's resume context via theAsyncTaskInfostruct.This will be used by lldb, but since this data is not specific to lldb it seems reasonable to include it generally.