Skip to content

[IRGen] Support generic but concrete metatypes with hasSymbol #77172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Oct 22, 2024

The current code was calling into a getAddr routine that did not want any form of generic type, even if it were concrete. Check if we have a generic type and call into the right getAddr.

Should resolve: rdar://138067133

@Azoy Azoy requested a review from rjmccall as a code owner October 22, 2024 20:27
@Azoy
Copy link
Contributor Author

Azoy commented Oct 22, 2024

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Oct 23, 2024

@swift-ci please test macOS

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Azoy Azoy merged commit 92d5656 into swiftlang:main Oct 23, 2024
5 checks passed
@Azoy Azoy deleted the generic-concrete-hassymbol branch October 23, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants