Sema: Undo changes in chronological order in SolverTrail::undo() #77174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Oct 22, 2024
xedin
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
LGTM! I feel like dealing with constraints after binding a type variable is an overkill, we might get away with keeping the set as is but using simplifyType during BindingSet construction because all of the logic to compute flags (i.e. pontential incomplete, literal, delayed etc.) moved there.
slavapestov
force-pushed
the
fix-undo-order
branch
from
6cd170f to
82a21eb
Compare
slavapestov
requested review from
artemcm,
tshortli and
DougGregor
as code owners
slavapestov
force-pushed
the
fix-undo-order
branch
from
82a21eb to
3867242
Compare
…omInference(Type) overloads
slavapestov
force-pushed
the
fix-undo-order
branch
from
3867242 to
a19c92a
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a loose end from my SolverScope refactoring. We would undo all fixed type variable bindings first and then undo the graph updates, because the graph updates were recorded in the wrong order with respect to type variable bindings. By refactoring the logic here a little we can undo changes in the order they were recorded, eliminating a second pass over the trail.