Miscellaneous solver cleanups #77178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
jckarter and
rjmccall
as code owners
Most constraints don't have a fix, so we can tail-allocate the fix. This saves 16 bytes per constraint, because it also eliminates some padding.
OverloadChoice is rather large, 40 bytes.
…tem::generateOverloadConstraints()
These functions are never called while undoing a change; so we want to assert if we have an active undo instead of silently not recording the change.
…containing ParameterizedProtocolType This fixes a soundness hole. We can't just match up the primary associated types of different protocols.
slavapestov
force-pushed
the
misc-solver-cleanups
branch
from
61a8243 to
8beaa7b
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
xedin
approved these changes
Oct 23, 2024
| IsIsolated(false), | ||
| : Kind(Kind), HasFix(false), HasRestriction(false), IsActive(false), | ||
| IsDisabled(false), IsDisabledForPerformance(false), RememberChoice(false), | ||
| IsFavored(false), IsIsolated(false), |
There was a problem hiding this comment.
I’d appreciate if we could land some of these after favoring changes since it takes time to rebase all these small changes in a proper way because favoring changes modify places in CSStep and Constraint…
There was a problem hiding this comment.
Actually I checked and this PR does not cause any conflicts with solver-perf, however there is a trivial conflict currently because of this that already landed on main: e0b6a96
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.