Sema: Allow resilient modules to add enum elements without breaking clients #77191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
force-pushed
the
swift6-nonexhaustive-switch-with-unknown-default-should-not-be-an-error
branch
2 times, most recently
from
c0a02f0 to
f08ebfc
Compare
|
@swift-ci please test |
hborla
approved these changes
Oct 23, 2024
…lients. In the implementation of swiftlang#73472, warnings about uncovered cases were upgraded to errors in switches covering enums with an `@unknown default` case. This change was a mistake; it should not be source breaking for a resilient library to add new cases to a non-frozen enum. Resolves rdar://138488976.
tshortli
force-pushed
the
swift6-nonexhaustive-switch-with-unknown-default-should-not-be-an-error
branch
from
f08ebfc to
0ac8cd3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
|
swiftlang/swift-foundation#1004 @swift-ci please smoke test Windows |
|
@swift-ci please smoke test Windows |
tshortli
deleted the
swift6-nonexhaustive-switch-with-unknown-default-should-not-be-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the implementation of #73472, warnings about uncovered cases were upgraded to errors in switches covering enums with an
@unknown defaultcase. This change was a mistake; it should not be source breaking for a resilient library to add new cases to a non-frozen enum.Resolves rdar://138488976.