Parse: Save and restore InFreestandingMacroArgument when delayed parsing #77210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla and
xedin
as code owners
Closures appearing in freestanding macro arguments don't have discriminators assigned, since we don't actually emit them. Similarly we skip recording opaque return types that appear in macro arguments, since they don't get emitted. However this logic didn't take delayed parsing into account, which must save and restore the InFreestandingMacroArgument bit correctly. As a result, if the freestanding macro argument contained a closure which contained a local function with a declaration that has an opaque return type, we would crash in serialization from attempting to mangle an opaque return type nested inside of a closure without a discriminator. Fixes rdar://135445004
slavapestov
force-pushed
the
fix-rdar135445004
branch
from
9bc6e8f to
9d85221
Compare
hborla
approved these changes
Oct 24, 2024
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closures appearing in freestanding macro arguments don't have discriminators assigned, since we don't actually emit them.
Similarly we skip recording opaque return types that appear in macro arguments, since they don't get emitted.
However this logic didn't take delayed parsing into account, which must save and restore the InFreestandingMacroArgument bit correctly.
As a result, if the freestanding macro argument contained a closure which contained a local function with a declaration that has an opaque return type, we would crash in serialization from attempting to mangle an opaque return type nested inside of a closure without a discriminator.
Fixes rdar://135445004